-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) #279
8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) #279
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval JDK-8311964 request |
@sendaoYan |
Webrevs
|
Hi @sendaoYan |
Thanks, I will check all mine PR there few days. |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/approval JDK-8311964 request "Clean backport. Backport has been verified. Only change the testcases, the risk is low." |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/integrate |
@sendaoYan |
I think is PR base is too old, bot says there are 318 commits ahead of it. Can you please merge from master to see if it still works? |
I have merged from master just now. Thanks for the advice. |
/integrate |
@sendaoYan |
/sponsor |
@TheRealMDoerr @sendaoYan Pushed as commit fbb0f4c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks. |
Hi,
Clean backport of JDK-8311964. Backport has been verified as bellow. Only change the testcases, the risk is low.
There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags.
test command:
After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client.
Thanks,
-sendao
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/279/head:pull/279
$ git checkout pull/279
Update a local copy of the PR:
$ git checkout pull/279
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/279/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 279
View PR using the GUI difftool:
$ git pr show -t 279
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/279.diff
Webrev
Link to Webrev Comment