Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) #279

Closed

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 21, 2024

Hi,

Clean backport of JDK-8311964. Backport has been verified as bellow. Only change the testcases, the risk is low.

There 3 testcases run complaint "Unrecognized VM option" with linux-x86-client-release jdk before this PR. LoopUnswitching, OptimizeFill and StressCCP are all C2 flags.
test command:

rm -rf tmp/ ; jtreg -v:fail,error -nr -w tmp -jdk:build/linux-x86-client-release/images/jdk/ test/hotspot/jtreg/compiler/loopopts/TestBackedgeLoadArrayFillMain.java test/hotspot/jtreg/compiler/loopopts/TestInfiniteLoopWithUnmergedBackedgesMain.java test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckCmpUOverflowVsSub.java 2>&1 | grep "Unrecognized VM option"

image

After this PR, there 3 testcases won't be selected when the test jdk is linux-x86-client.
image

Thanks,
-sendao


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8311964 needs maintainer approval

Issue

  • JDK-8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/279/head:pull/279
$ git checkout pull/279

Update a local copy of the PR:
$ git checkout pull/279
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 279

View PR using the GUI difftool:
$ git pr show -t 279

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/279.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 024133b089d911dcc3ea70dfdaa6b150b14a9eb4 8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags) Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 21, 2024
@sendaoYan
Copy link
Member Author

/approval JDK-8311964 request

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan
JDK-8311964: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 21, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 21, 2024

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Feb 22, 2024

Hi @sendaoYan
Same as with your orther request. The comment is missing. Please read https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix
I won't check and comment all of your backports, instead I will remove the tag of all the ones I find today. Please double check all of them, you find a list here: https://github.com/pulls if you are logged in to github.

@openjdk openjdk bot removed the approval label Feb 22, 2024
@sendaoYan
Copy link
Member Author

Hi @sendaoYan Same as with your orther request. The comment is missing. Please read https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix I won't check and comment all of your backports, instead I will remove the tag of all the ones I find today. Please double check all of them, you find a list here: https://github.com/pulls if you are logged in to github.

Thanks, I will check all mine PR there few days.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311964: Some jtreg tests failing on x86 with error 'unrecognized VM options' (C2 flags)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@sendaoYan sendaoYan marked this pull request as ready for review March 18, 2024 12:00
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval JDK-8311964 request "Clean backport. Backport has been verified. Only change the testcases, the risk is low."

@openjdk
Copy link

openjdk bot commented Apr 11, 2024

@sendaoYan
JDK-8311964: The approval request has been updated successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 11, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 9, 2024
@openjdk
Copy link

openjdk bot commented May 9, 2024

@sendaoYan
Your change (at version 93cbcc4) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

I think is PR base is too old, bot says there are 318 commits ahead of it. Can you please merge from master to see if it still works?

@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label May 13, 2024
@sendaoYan
Copy link
Member Author

I think is PR base is too old, bot says there are 318 commits ahead of it. Can you please merge from master to see if it still works?

I have merged from master just now. Thanks for the advice.

@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@sendaoYan
Your change (at version 02c1674) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 13, 2024

Going to push as commit fbb0f4c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • bddd6a7: 8321925: sun/security/mscapi/KeytoolChangeAlias.java fails with "Alias <246810> does not exist"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2024
@openjdk openjdk bot closed this May 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@TheRealMDoerr @sendaoYan Pushed as commit fbb0f4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants