Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible #1340

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 17, 2025

I backport this for parity with 21.0.7-oracle

The issue addressed by this change is fixed.
But the test does not exactly do what is requested by the description.
Maybe the description is shaky, or mac behaves different from windows and
the description is not tailerd for this. E.g., it does not anouce the cell position if
entering the table. It does so when reordering the columns. Also, some of the
buttons in the third test are not visible. They work, though.
I verified this is the same if run on jdk head.


Progress

  • JDK-8341453 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1340/head:pull/1340
$ git checkout pull/1340

Update a local copy of the PR:
$ git checkout pull/1340
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1340/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1340

View PR using the GUI difftool:
$ git pr show -t 1340

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1340.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f1f15370fa26e4c1121abadb8938c0126c6f4f24 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible Jan 17, 2025
@openjdk
Copy link

openjdk bot commented Jan 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 17, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jan 18, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Jan 20, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 20, 2025

Going to push as commit d6b7816.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 4a8fbb3: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos
  • 920f02b: 8341412: Various test failures after JDK-8334305
  • 99a9299: 8311546: Certificate name constraints improperly validated with leading period
  • 5b377a3: 8334305: Remove all code for nsk.share.Log verbose mode
  • abd8902: 8329322: Convert PageFormat/Orient.java to use PassFailJFrame
  • fe321bb: 8320676: Manual printer tests have no Pass/Fail buttons, instructions close set 1
  • ded4113: 8326525: com/sun/tools/attach/BasicTests.java does not verify AgentLoadException case
  • aed5fd3: 8313633: [macOS] java/awt/dnd/NextDropActionTest/NextDropActionTest.java fails with java.lang.RuntimeException: wrong next drop action!

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 20, 2025
@openjdk openjdk bot closed this Jan 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2025
@openjdk
Copy link

openjdk bot commented Jan 20, 2025

@GoeLin Pushed as commit d6b7816.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant