-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible #1340
8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible #1340
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
Going to push as commit d6b7816.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 21.0.7-oracle
The issue addressed by this change is fixed.
But the test does not exactly do what is requested by the description.
Maybe the description is shaky, or mac behaves different from windows and
the description is not tailerd for this. E.g., it does not anouce the cell position if
entering the table. It does so when reordering the columns. Also, some of the
buttons in the third test are not visible. They work, though.
I verified this is the same if run on jdk head.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1340/head:pull/1340
$ git checkout pull/1340
Update a local copy of the PR:
$ git checkout pull/1340
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1340/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1340
View PR using the GUI difftool:
$ git pr show -t 1340
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1340.diff
Using Webrev
Link to Webrev Comment