-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337795: Type annotation attached to incorrect type during class reading #1252
base: pr/1251
Are you sure you want to change the base?
Conversation
👋 Welcome back cushon! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
55c9cd4
to
fcc6a21
Compare
@cushon Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
This is a backport of JDK-8337795, which is a follow-up to JDK-8225377.
Progress
Integration blocker
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1252/head:pull/1252
$ git checkout pull/1252
Update a local copy of the PR:
$ git checkout pull/1252
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1252/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1252
View PR using the GUI difftool:
$ git pr show -t 1252
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1252.diff
Using Webrev
Link to Webrev Comment