8267068: Incomplete @throws javadoc for various javax.crypto.spec classes

[mcpowers]

JDK-8267068

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request matching fixVersion 25 to be approved (needs to be created)

Issue

• JDK-8267068: Incomplete @throws javadoc for various javax.crypto.spec classes (Bug - P4)

Reviewers

• Jamil Nimeh (@jnimeh - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23188/head:pull/23188
$ git checkout pull/23188

Update a local copy of the PR:
$ git checkout pull/23188
$ git pull https://git.openjdk.org/jdk.git pull/23188/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23188

View PR using the GUI difftool:
$ git pr show -t 23188

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23188.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mpowers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcpowers This change is no longer ready for integration - check the PR body for details.

[openjdk]

@mcpowers The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7a4b8596)

[jnimeh]

Looks good to me.

[seanjmullan]

This will need a CSR because you are adding a new exception to the RC5ParameterSpec constructor.

[seanjmullan]

/csr

[openjdk]

@seanjmullan has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@mcpowers please create a CSR request for issue JDK-8267068 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[seanjmullan]

@valeriepeng can you also review this? Thanks.

[seanjmullan]

can you fix this grammatical issue while you are changing this:

s/outside/are outside/

[mcpowers]

So a CSR is needed even if the only change is to sync javadoc with the code?

[seanjmullan]

So a CSR is needed even if the only change is to sync javadoc with the code?

Yes, because that is still considered a specification change to a public API.