Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7903890: jcstress: Rewrite/amend Singleton and Lazy primitives samples #155

Merged

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 29, 2024

It is obvious we do not have a good narrative around these, so let's add some.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • CODETOOLS-7903890: jcstress: Rewrite/amend Singleton and Lazy primitives samples (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jcstress.git pull/155/head:pull/155
$ git checkout pull/155

Update a local copy of the PR:
$ git checkout pull/155
$ git pull https://git.openjdk.org/jcstress.git pull/155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 155

View PR using the GUI difftool:
$ git pr show -t 155

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jcstress/pull/155.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 29, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 29, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title CODETOOLS-7903890: jcstress: Rewrite/amend Singleton and Lazy primitives samples 7903890: jcstress: Rewrite/amend Singleton and Lazy primitives samples Nov 29, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2024

Webrevs

@shipilev shipilev merged commit 7b124f6 into openjdk:master Dec 3, 2024
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant