New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature. Apply Styles to TDataGrid and TPagination, Modify Test Code #25

Merged

kkusaeng merged 13 commits into develop from feature-pagination-grid

Jan 23, 2024

Collaborator

kkusaeng commented Jan 22, 2024 •

edited by Siyeop

Loading

Key Changes of PR

Add jumper in TPagination 🏃🏻‍♂️
Apply DataGrid, Pagination style 💃🏻
Modify TPagination and TDataGrid test code 🧑🏻‍💻

kkusaeng added 5 commits

January 22, 2024 13:10


          feature. Modify TPagination and add test code

8664eb6


          feature. Modify TDataGrid style

605c8b5


          feature. Modify TDataGrid test code

d618bdf


          feature. Modify TDataGrid test code

4c86ceb


          Merge remote-tracking branch 'origin/feature-pagination-grid' into fe…

dda4fa8

…ature-pagination-grid

Siyeop reviewed

View reviewed changes

src/components/data-container/data-grid/TDataGrid.tsx Show resolved Hide resolved

Siyeop reviewed

View reviewed changes

src/components/data-container/pagination/TPagination.tsx Outdated Show resolved Hide resolved

Siyeop reviewed

View reviewed changes

src/styles/component/data-container/data-grid/TDataGrid.scss Outdated Show resolved Hide resolved

Siyeop reviewed

View reviewed changes

src/styles/component/data-container/data-grid/TDataGrid.scss Outdated Show resolved Hide resolved

Siyeop reviewed

View reviewed changes

src/components/data-container/pagination/TPagination.tsx Outdated Show resolved Hide resolved

Siyeop reviewed

View reviewed changes

src/components/data-container/pagination/TPagination.tsx Outdated Show resolved Hide resolved

Siyeop reviewed

View reviewed changes

src/components/data-container/pagination/TPagination.tsx Outdated Show resolved Hide resolved

Siyeop reviewed

View reviewed changes

src/styles/component/data-container/pagination/TPagination.scss Outdated Show resolved Hide resolved

Siyeop reviewed

View reviewed changes

src/components/data-container/pagination/TPagination.tsx Show resolved Hide resolved

Siyeop requested changes

View reviewed changes

Member

Siyeop left a comment

수정 후에 이야기 해주세요.
jumper 가 제대로 작동하지 않는 문제때문에
다시 한 번 보고 머지하는 것이 안전할 것 같습니다.

고생 많으셨습니다. 👍

kkusaeng added 5 commits

January 22, 2024 19:05


          feature. Modify TDataGrid and TPagination

08bb431


          Merge remote-tracking branch 'origin/feature-pagination-grid' into fe…

eb639df

…ature-pagination-grid


          feature. Modify TPagination icon name

96abe4f


          feature. Modify TPagination test code

63ec518


          feature. Modify TPagination style

7b4309c

Siyeop reviewed

View reviewed changes

src/components/data-container/data-grid/TDataGrid.tsx Outdated Show resolved Hide resolved

kkusaeng added 2 commits

January 23, 2024 11:09


          feature. Modify TPagination style

7bcda57


          Merge remote-tracking branch 'origin/feature-pagination-grid' into fe…

fb066b4

…ature-pagination-grid

# Conflicts:
#	src/styles/component/data-container/pagination/TPagination.scss

Siyeop approved these changes

View reviewed changes

Member

Siyeop left a comment

리뷰 다 처리해주시느라 고생 많으셨습니다.

pagination의 숫자 입력 validation 관련 내용은 별도 이슈로 등록하고
이 PR은 여기까지하고 머지하는게 좋을 것 같습니다.


          feature. Modify TPagination and TActionbar

cfa6ccb

kkusaeng merged commit f580170 into develop

2 checks passed

kkusaeng deleted the feature-pagination-grid branch

January 23, 2024 04:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet