Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add slack notification to E2E test workflow #97

Merged
merged 1 commit into from
Jun 22, 2022
Merged

add slack notification to E2E test workflow #97

merged 1 commit into from
Jun 22, 2022

Conversation

robertchoi80
Copy link
Contributor

@robertchoi80 robertchoi80 requested review from zugwan and ktkfree June 22, 2022 07:38
ktkfree
ktkfree approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@ktkfree ktkfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 스타일좀 적용해서 실패시에는 시뻘건 색으로 겁나 크게 메시지 뿌려주면 좋을듯 합니다 ㅎㅎ

@bluejayA
Copy link
Contributor

나중에 스타일좀 적용해서 실패시에는 시뻘건 색으로 겁나 크게 메시지 뿌려주면 좋을듯 합니다 ㅎㅎ

가장 확실한 방법중 하나는 임원들 메일로 뿌리는거죠.. ^^

@zugwan zugwan merged commit 2b4aaaf into main Jun 22, 2022
@zugwan zugwan deleted the add_notification branch June 22, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktkfree ktkfree ktkfree approved these changes

@zugwan zugwan zugwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertchoi80 @bluejayA @zugwan @ktkfree