Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi keycloak client id #76

Merged
merged 2 commits into from
Apr 6, 2022
Merged

multi keycloak client id #76

merged 2 commits into from
Apr 6, 2022

Conversation

seungkyua
Copy link
Contributor

multi client 지원

@ktkfree
Copy link
Contributor

ktkfree commented Apr 5, 2022

ClientId의 의미가 조금 모호한 것 같습니다.

ClientId : ${REALMS}-${CLIENT_NAME} ( 예. XXXXXXX-portal )
ClientName : ${구 CLIENT_ID} ( 예. portal )

요 정도로 변경하는게 어떨까요?

@seungkyua
Copy link
Contributor Author

ClientId의 의미가 조금 모호한 것 같습니다.

ClientId : ${REALMS}-${CLIENT_NAME} ( 예. XXXXXXX-portal ) ClientName : ${구 CLIENT_ID} ( 예. portal )

요 정도로 변경하는게 어떨까요?

That's good idea

@seungkyua
Copy link
Contributor Author

수정 및 테스트 완료

ktkfree
ktkfree approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@ktkfree ktkfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClientName, ClientId, ClientUUID 총 3개의 개념을 알고 있어야 겠습니다.

@ktkfree ktkfree merged commit 229ab49 into openinfradev:release-v2 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktkfree ktkfree ktkfree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seungkyua @ktkfree