feature. add tks-portal flow. #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktkfree
force-pushed
the
add_tks_portal
branch
4 times, most recently
from
124d68f to
3536ca1
Compare
seungkyua
reviewed
Mar 22, 2022
seungkyua
reviewed
Mar 22, 2022
seungkyua
reviewed
Mar 22, 2022
Comment on lines
+1074
to
+1076
| envFrom: | ||
| - secretRef: | ||
| name: "github-tks-mgmt-token" |
There was a problem hiding this comment.
지금은 tks-management 지만 변수로 받아야 하지 않을까요?
There was a problem hiding this comment.
이 토큰에서 orgname 가져오도록 변경하였습니다.
intelliguy
approved these changes
Mar 22, 2022
| CLIENT_ID={{inputs.parameters.client_id}} | ||
| ADD_MAPPER={{inputs.parameters.add_mapper}} | ||
| kube_params="" | ||
| kube_secret=$(kubectl get secret -n argo tks-admin-kubeconfig-secret -o jsonpath="{.data.value}" | base64 -d) |
There was a problem hiding this comment.
고정이니 secret mount 하는 방법을 사용하는 것이 더 좋습니다.
다른 flow에서도 그렇게 사용하고 있구요 (일관성측면에서도)
There was a problem hiding this comment.
네 요 부분은 create-client workflow 로 통합할때 같이 작업되면 좋겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tks-portal 을 설치하는 workflow 를 추가합니다.
tks-portal 에서 요구하는 파라미터가 대부분 동적인 값들이라서 @robertchoi80 님 변경내역 참고하여 CHANGEME 라는 값을 converting 하는 로직으로 구현하였습니다.