Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial. rename base branch name for creating contract #384

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

ktkfree
Copy link
Contributor

@ktkfree ktkfree commented Aug 28, 2024

admin cluster 를 tag 기준(branch가 아닌)으로 셋업할 경우 오류가 발생하는 부분을 수정하였습니다.

@zugwan HEAD detach 상태에서 remote 로 push 가 되지 않는 현상인데, 이 변경이 맞는건지 체크 바랍니다. 테스트는 완료하였습니다.

@ktkfree ktkfree requested a review from zugwan August 28, 2024 06:31
Copy link
Contributor

@zugwan zugwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최초 작성할 때 브랜치 기준일 것으로 가정이 되었었네요. 새로운 임시 브랜치 생성 후 사용하는 것이 맞습니다.

@zugwan zugwan merged commit 5f3ca4a into develop Aug 29, 2024
3 checks passed
@zugwan zugwan deleted the git_tag branch August 29, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants