-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Service-Mesh workflow for tks and decapod #36
Merged
bluejayA
merged 2 commits into
openinfradev:main
from
seungkyua:20220215_tks_servicemesh_merge
Mar 8, 2022
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
특별한 이슈가 없다면 삭제 인터페이스를 LMA 와 유사하게(가능하다면 동일하게) 맞춰도 괜찮을 것 같습니다.
동일한 계위의 서비스가 계속 생길텐데, 가능하다면 유사한 인터페이스를 가지는게 좋을 것 같아요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lma 와 좀 내용이 달라요. 일단 gateway 는 추가로 다른 namespace 에 설치될 수 있어서 해당 namespace 의 gateway 만 삭제할 수 있고, istiod 가 revision 으로 여러 버전이 설치될 수 있어서 해당 버전만 지우는 작업도 해야 합니다.
추후에 istio-operator 는 제거하고 istio helm 으로 설치하면 파라미터를 좀 더 단순하게 할 수 있을 것 같네요.