Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20231108 release to deveop #314

Merged
merged 7 commits into from
Nov 8, 2023

Merge pull request #308 from openinfradev/develop

5bd8575
Select commit
Loading
Failed to load commit list.
Merged

20231108 release to deveop #314

Merge pull request #308 from openinfradev/develop
5bd8575
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks completed Nov 8, 2023 in 7s

3 secrets uncovered!

3 secrets were uncovered from the scan of 138 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #314: release 👉 develop (7 commits)

  • Pull request #309: release 👉 main (131 commits)

GitGuardian id Secret Commit Impacted PRs Filename
6177710 GitHub Access Token 417b005 #309 deploy_apps/tks-primary-cluster.yaml View secret
8521845 Kubernetes Cluster Credentials 544d1c6 #309 b View secret
8521845 Kubernetes Cluster Credentials 35abf8f #309 b View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!