-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hanu-reference template as standard user site template #30
Conversation
이 PR과는 별개지만, hanu-reference, hanu-reference-offline 의 이름을 변경하면 좋겠습니다. |
decapod-bootstrap 쪽과 배포에 관련된 대부분의 workflow들이 영향을 받을 것으로 보이는데, 정확한 건 좀더 추적을 해봐야 알 것 같습니다. |
# If these kinds of apps increases, then they might be defined as black list | ||
# and then removed by FOR loop iteration. | ||
# For now, this hardcoding seems enough. | ||
rm -rf template-std/openstack template-std/decapod-controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지워야할 템플릿의 위치가 template-std/openstack
, template-std/decapod-controller
가 아닌
template-std/hanu-reference/openstack
, template-std/hanu-reference/decapod-controller
입니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아~ openinfradev/dep-tks-user-site-template@7d23127 이 먼저 머지되어야 제대로 동작하네요. (openinfradev/dep-tks-user-site-template#6 중 하나의 커밋입니다)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jaesang 요거 지금은 동작할 테니 resolve 부탁드립니다. 이 PR까지 머지되고 나면 최종 테스트 한번 더 해볼 예정입니다.
https://github.com/openinfradev/tks-issues/issues/76
tks-user-site-template 중 std 템플릿은 decapod-site의 hanu-reference 를 공유하기로 결정함에 따라, 최초 contract-repo 생성시 hanu-reference 를 가져오는 부분 추가함.
사실 엄밀히는 tks-cluster 디렉토리 부분만 tks 쪽으로 빼놓고 합치는게 나머지는 decaopd 쪽에서 가져오는게 맞지만, 복잡도 증가를 우려하는 의견이 있으므로 우선은 이정도로만 구현합니다.