-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main merge ( 20230814 ) #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bug fix: add safety checks to avoid accidental client removal
bluejayA
reviewed
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint error 나는데요
@cho4036 님 lint error 확인 부탁 드립니다. 이 lint error 는 cicd cluster 세팅이 잘못되어 항상 발생하던 건인지 모르겠네요 |
action 을 보니 이 변경으로 인한 lint error 가 아닌 기존에 발생하던 lint 자체의 오류로 보입니다. |
merge 할까요? |
넵, lint 는 다시 세팅해야 할 듯 합니다. |
change image repo from harbor-cicd to harbor
deploy workload for removing buckets on the user cluster
piggyback - ignore error when loki dose not exist
bugfix: fix a volume name, namespace and so on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.