New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use release branch of app-serve-template #220

Merged

ktkfree merged 1 commit into release from modify-template-branch

Jul 24, 2023

Contributor

robertchoi80 commented Jul 24, 2023

release 에서는 app-serve-template의 release 브랜치를 바라보도록 싱크 맞춤.


          use release branch of app-serve-template

492db67

robertchoi80 requested a review from ktkfree

July 24, 2023 04:49

ktkfree approved these changes

View reviewed changes

Contributor

ktkfree left a comment

일단 qa 테스트를 위해 승인하겠습니다.
각 환경별로 admin cluster 에서 branch 정보를 secret 으로 관리하고, 이 정보를 사용하도록 하는 것이 좋겠습니다.

추후 main, develop merge 시 이 commit 은 제외하도록 유의해야 겠습니다.

ktkfree merged commit cf07af9 into release

ktkfree deleted the modify-template-branch branch

July 24, 2023 04:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet