app-serving: override env vars for legacy spring app #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertchoi80
requested review from
seungkyua,
zugwan,
ktkfree,
cho4036 and
Siyeop
ktkfree
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
legacy spring app 배포를 위해 사용하는 tomcat 차트의 경우, 환경변수를 넣기 위한 value의 구조가 springboot 차트와 다름.
이 경우 workflow 상에서 인자로 전달받은 환경변수 문자열을 tomcat value 구조에 맞게 후가공해서 사용하도록 함.
https://github.com/openinfradev/tks-issues/issues/753