Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: change keycloak client logic to support multiple uris #186

Merged
merged 2 commits into from
May 22, 2023
Merged

bug fix: change keycloak client logic to support multiple uris #186

merged 2 commits into from
May 22, 2023

Conversation

cho4036
Copy link
Contributor

@cho4036 cho4036 commented May 19, 2023

기존 로직

  • grafana 설치 시 client가 있으면 redirectUri 추가 과정 스킵
  • grafana 삭제 시 client를 삭제

변경 사항

  • grafana 설치 시, client가 있으면 기존 client에 redirectUr를 추가
  • grafana 삭제 시, client에 자신을 제외한 다른 endpoint가 있을 시 자신의 endpoint만 제거. 자신이 마지막일 경우 client 삭제

@ktkfree ktkfree merged commit c80cf00 into openinfradev:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktkfree ktkfree ktkfree approved these changes

@zugwan zugwan Awaiting requested review from zugwan

@intelliguy intelliguy Awaiting requested review from intelliguy

@robertchoi80 robertchoi80 Awaiting requested review from robertchoi80

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cho4036 @ktkfree