Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tks api migration #152

Merged
merged 5 commits into from
Apr 6, 2023
Merged

Tks api migration #152

merged 5 commits into from
Apr 6, 2023

Conversation

ktkfree
Copy link
Contributor

@ktkfree ktkfree commented Apr 6, 2023

하드코딩된 계정 정보를 secret 에서 읽어오도록 변경합니다.

@gitguardian
Copy link

gitguardian bot commented Apr 6, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
6177710 GitHub Access Token 7028895 deploy_apps/tks-primary-cluster.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ktkfree ktkfree merged commit 44d1a31 into main Apr 6, 2023
@ktkfree ktkfree deleted the tks-api-migration branch April 6, 2023 10:26
@ktkfree
Copy link
Contributor Author

ktkfree commented Apr 6, 2023

내일 테스트를 위해 리뷰없이 merge 합니다. 관련사항은 따로 공유드리겠습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant