tks stack 워크플로우 템플릿 추가 #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tks-cli workflow template is used for both e2e tests and tks stacks.
zugwan
requested review from
ktkfree,
intelliguy,
robertchoi80,
seungkyua and
kyuho24
ktkfree
approved these changes
Oct 7, 2022
|
link 확인해주시면 승인하겠습니다. |
lint 말씀하시는 것이죠? fake kubeconfig를 통해 argo template lint를 수행하고 있는데 templateRef를 통해 참조하는 외부 템플릿을 인식하지 못하기 때문에 발생하는 오류 입니다. lint를 위한 실제 클러스터 구성과 연동이 필요한 상황입니다. |
|
merge 후 console 과 integration test 하겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
클러스터와 서비스를 한 번에 설치하기 위한 스택 워크플로우 템플릿을 추가합니다.
e2e 테스트 구현을 재사용하였고 e2e 테스트와 tks stack이 공통으로 사용되는 부분은 tks-cli 워크플로우 템플릿으로 분리하였습니다.