Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helm chart for deployment #112

Merged
merged 15 commits into from
Sep 14, 2022
Merged

Use helm chart for deployment #112

merged 15 commits into from
Sep 14, 2022

Conversation

robertchoi80
Copy link
Contributor

@robertchoi80 robertchoi80 commented Aug 30, 2022

#111 PR + #306 번 티켓 내용을 합한 PR 입니다.

111번 PR 머지 후에 별도의 PR 올릴까 했으나, 리뷰 두번 요청드리는 것보다 diff가 좀 길어져도 그냥 한번에 끝내는 것이 나을 것 같아 합쳐서 올립니다.
후자의 내용은 kustomize 기반 manifest 대신 helm chart를 사용하여 배포하도록 변경한 부분입니다.
helm chart는 https://github.com/openinfradev/app-serve-template 에 들어있습니다.

@ktkfree
Copy link
Contributor

ktkfree commented Aug 30, 2022

status 가 4개인것 같은데, deploying, building 상태는 어떻게 표현하는게 좋을까요?
웹화면에 표시하기 위함입니다.

BUILD_SUCCESS
BUILD_FAILED
DEPLOY_SUCCESS
DEPLOY_FAILED

& fix hard-coded jar name
@robertchoi80
Copy link
Contributor Author

robertchoi80 commented Aug 31, 2022

status 가 4개인것 같은데, deploying, building 상태는 어떻게 표현하는게 좋을까요? 웹화면에 표시하기 위함입니다.

BUILD_SUCCESS BUILD_FAILED DEPLOY_SUCCESS DEPLOY_FAILED

첨에 생각한건 아래 항목들인데, 지금 workflow 구현을 보면 BUILDIING과 DEPLOYING은 사용하고 있지는 않습니다.

  • PREPAIRING, BUILDING, BUILD_FAILED, BUILD_SUCCESS, DEPLOYING, DEPLOY_SUCCESS, DEPLOY_FAILED

제대로 하려면, 이미지 빌드 시작 전에 BUILDING으로 업뎃해주고, 배포 단계 시작 전에 DEPLOYING 으로 업뎃해주는 부분이 추가되어야겠네요.

(update) 위 부분 추가 완료했습니다. 이제 BUILDING, DEPLOYING도 사용합니다.

such as BUILDING and DEPLOYING
@robertchoi80 robertchoi80 requested a review from ktkfree September 1, 2022 04:19
@robertchoi80 robertchoi80 merged commit 7744c3e into main Sep 14, 2022
@robertchoi80 robertchoi80 deleted the use-helm-chart branch September 14, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants