Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement: mocking gRPC client for info #4

Merged
merged 1 commit into from
May 25, 2021
Merged

implement: mocking gRPC client for info #4

merged 1 commit into from
May 25, 2021

Conversation

estherk0
Copy link
Contributor

  • gRPC client 를 mocking하기 위해 gomock package와 pbgo/mock package를 사용.
  • 기존의 grpc-client/info는 mock client를 사용할 수 있도록 변경

seungkyua
seungkyua approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@seungkyua seungkyua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seungkyua seungkyua merged commit 0317801 into main May 25, 2021
@estherk0 estherk0 deleted the mock_grpc_client branch May 25, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seungkyua seungkyua seungkyua approved these changes

@intelliguy intelliguy Awaiting requested review from intelliguy

@Jaesang Jaesang Awaiting requested review from Jaesang

@robertchoi80 robertchoi80 Awaiting requested review from robertchoi80

@zugwan zugwan Awaiting requested review from zugwan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estherk0 @seungkyua