Implement postgresql package #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estherk0
requested review from
Jaesang,
zugwan,
intelliguy,
robertchoi80 and
seungkyua
estherk0
force-pushed
the
dev-integrationDB
branch
from
0396ca2 to
592561a
Compare
pkg/postgresql/accessor.go
Outdated
| return p.getAll(tx, fields, table) | ||
| } | ||
|
|
||
| args := getValueSliceFromMaps(conditions) |
There was a problem hiding this comment.
변수명을 좀 통일하면 더 좋을 것 같습니다. 지금 함수마다, args, conditionValues 등 다른 이름으로 사용되고 있어서 통일하면 가독성이 더 좋아질거 같아요. 저 개인적으로는 Delete()에 사용하신 방식이 제일 명확한 거 같습니다.
There was a problem hiding this comment.
네 conditionValues, conditionKeySql로 통일 시켰습니다~
robertchoi80
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/pq와 database/sql을 사용하는 postgresql package 구현
주요 기능
go-sqlmock library 를 사용한 unittest code 작성