Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement grpc-client package #2

Merged
merged 2 commits into from
Apr 21, 2021
Merged

implement grpc-client package #2

merged 2 commits into from
Apr 21, 2021

Conversation

estherk0
Copy link
Contributor

  • grpc-client package를 구현하여 client 코드를 여러 서비스에서 재사용 할 수 있도록함.
  • 계약 생성 시, CspInfo를 생성하도록 info service에 요청

@estherk0 estherk0 self-assigned this Apr 19, 2021
seungkyua
seungkyua reviewed Apr 21, 2021
View reviewed changes
Copy link
Contributor

@seungkyua seungkyua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grpc client 에서 info client 는 tks-info 에 있어야 하지 않을까요?

@estherk0
Copy link
Contributor Author

grpc client 에서 info client 는 tks-info 에 있어야 하지 않을까요?

개발할때 편의를 위해서 pkg를 사용하는 쪽에 넣었는데요. 각 서비스의 grpc-client는 각 서비스 pkg에 넣는걸로 정한다면 변경하도록 하겠습니다.

@seungkyua seungkyua merged commit 2fe280d into main Apr 21, 2021
@estherk0 estherk0 deleted the grpc-client branch April 21, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seungkyua seungkyua seungkyua left review comments

@zugwan zugwan zugwan approved these changes

@Jaesang Jaesang Awaiting requested review from Jaesang

@intelliguy intelliguy Awaiting requested review from intelliguy

@robertchoi80 robertchoi80 Awaiting requested review from robertchoi80

Assignees

@estherk0 estherk0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estherk0 @zugwan @seungkyua