Cmd for service #15
Merged
Cmd for service #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugwan
approved these changes
Mar 22, 2022
ktkfree
reviewed
Mar 22, 2022
cmd/service_delete.go
Outdated
| data := pb.UninstallAppGroupsRequest{} | ||
| var appgroupIds []string | ||
| appgroupIds = []string{serviceId} | ||
| data.AppGroupIds = appgroupIds |
There was a problem hiding this comment.
중요한건 아닙니다. code readerbility 를 위해 아래와 같이 한줄로 표현해도 되지 않을까요?
data.AppGroupIds = []string{serviceId}
| Run: func(cmd *cobra.Command, args []string) { | ||
| if len(args) == 0 { | ||
| fmt.Println("You must specify cluster name.") | ||
| fmt.Println("Usage: tks cluster create <CLUSTERNAME> --contract-id <CONTRACTID> --csp-id <CSPID>") | ||
| os.Exit(1) | ||
| } | ||
| var conn *grpc.ClientConn | ||
| tksClusterLcmUrl = viper.GetString("tksClusterLcmUrl") |
There was a problem hiding this comment.
config file 위치 지정은 어디서 하나요?
There was a problem hiding this comment.
~/.tks-config.yaml입니다. tks help message에 표시되어요
There was a problem hiding this comment.
네 차후에 config 파일 위치도 입력 가능하게 하면 더 좋겠군요. 일단 지금은 머지할게요
|
default config 파일을 추가해주는 것도 좋겠습니다. |
|
merge 후 테스트가 급하니, merge 하고 테스트하면서 release branch 에서 진행해도 좋겠습니다. |
ktkfree
approved these changes
Mar 22, 2022
robertchoi80
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service 삭제 기능 추가하였습니다.
service 삭제 시 필요한 service id 확보를 위해 service list 기능도 추가하였습니다.
빌드 및 테스트)
#16 의 내용도 같이 포함하여서,
cmd/service_list.go,cmd/service_delete.go만 보시면 되겠습니다.