feature. change apply rule logic to reload #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktkfree
force-pushed
the
fix_snr
branch
2 times, most recently
from
0881981 to
af08fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rule 적용 후 thanos-ruler pod 재시작이 아닌, reload 를 호출 하도록 변경합니다.
단, thanos에서 제공하는 reload api 가 한번에 적용되는게 아니고, 랜덤(?) 한듯 합니다.
따라서 마지막 update 된 시각 대비 2분동안 reload 를 호출하도록 하였습니다.