Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trivial. minor fix. #90

Merged
merged 2 commits into from
Jun 22, 2023
Merged

trivial. minor fix. #90

merged 2 commits into from
Jun 22, 2023

Conversation

ktkfree
Copy link
Contributor

@ktkfree ktkfree commented Jun 22, 2023

cloud Account 중 "INCLUSTER" name 이 포함된 경우는 테스트를 위해 특별한 처리를 하고 있습니다.
강제 삭제(Force Delete)의 경우, 이름에 INCLUSTER 가 포함되면 status 와 상관 없이 강제 삭제를 허용하도록 변경합니다.

@ktkfree ktkfree requested review from zugwan and Siyeop June 22, 2023 02:01
Siyeop
Siyeop approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@Siyeop Siyeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화면에서 secret 을 같이 보낼지 분기는 createdIAM 에만 의존하고 있습니다.

INCLUSTER 가 포함된 클라우드 계정의 createdIAM 값은 항상 false로 설정되게 되어있나요?
그게 아니라면 화면 추가 수정이 필요할 것 같습니다.

@ktkfree ktkfree merged commit 9dbe2a1 into develop Jun 22, 2023
@ktkfree ktkfree deleted the minor_fix branch June 22, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siyeop Siyeop Siyeop approved these changes

@zugwan zugwan Awaiting requested review from zugwan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktkfree @Siyeop