bug fix. 비밀번호 입력 관련 API의 에러코드 추가 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siyeop
reviewed
May 31, 2023
Comment on lines
+18
to
+19
| "A_INVALID_ID": "아이디가 존재하지 않습니다.", | ||
| "A_INVALID_PASSWORD": "비밀번호가 일치하지 않습니다.", |
There was a problem hiding this comment.
사이트마다 정책이 다르긴한데
둘을 구분하지 않고 리턴하는 경우가 많은 것 같긴합니다.
존재하는 아이디인지 알려주는 것 자체가 문제라고 생각하더라고요.
향후에 5회이상 잘못된 비밀번호 입력시 락 거는 기능 등이 추가될 때 정리한번 하면 좋을 것 같습니다.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
이 PR 머지 후에 화면도 수정하고 난 후에 |
ktkfree
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
비밀번호 오류에 대해 응답코드 401 -> 400 으로 변경 하였으며 에러 코드 "A_INVALID_PASSWORD"를 추가하였습니다.
추가 커밋:
minor fix: grafana endpoint에 대한 url 수정
minor fix: Organization 생성 시 전송하는 이메일 포맷 수정