Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-serving: rollback 비활성화 로직 버그 수정 #55

Merged
merged 2 commits into from
May 22, 2023
Merged

app-serving: rollback 비활성화 로직 버그 수정 #55

merged 2 commits into from
May 22, 2023

Conversation

robertchoi80
Copy link
Contributor

  • 각 task 들에 rollback 가능 여부를 tagging하는 로직에 버그가 있어 수정하였습니다.
  • helm_revision 필드의 기본값을 0으로 부여하도록 하였습니다.

Siyeop
Siyeop approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@Siyeop Siyeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Siyeop
Siyeop approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@Siyeop Siyeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Siyeop Siyeop merged commit f2e1359 into develop May 22, 2023
@ktkfree ktkfree deleted the add-default-rev branch June 19, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siyeop Siyeop Siyeop approved these changes

@ktkfree ktkfree Awaiting requested review from ktkfree

@seungkyua seungkyua Awaiting requested review from seungkyua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertchoi80 @Siyeop