Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-serving: add validation & etc #54

Merged
merged 3 commits into from
May 19, 2023
Merged

app-serving: add validation & etc #54

merged 3 commits into from
May 19, 2023

Conversation

robertchoi80
Copy link
Contributor

  • promote 대기 상태 또는 promote/abort 등의 작업 진행 중일 때 update 수행 불가하도록 validation 추가
  • delete 작업도 화면 파이프라인에 표시되도록 수정 (삭제 실패시 명확히 표현되도록/ 또한 rollback 등과의 일관성을 위해)
  • 특정 상태에서 rollback 불가능하도록 개선

@robertchoi80 robertchoi80 requested review from ktkfree and Siyeop May 19, 2023 07:21
Siyeop
Siyeop approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@Siyeop Siyeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Siyeop
Siyeop approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@Siyeop Siyeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robertchoi80
Copy link
Contributor Author

lint 체크는 library 코드에서 발생하는 것이라 본 PR 과는 무관합니다. 바로 머지합니다.

@robertchoi80 robertchoi80 merged commit 042b7d8 into develop May 19, 2023
@ktkfree ktkfree deleted the add-validation-asa branch June 19, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siyeop Siyeop Siyeop approved these changes

@ktkfree ktkfree Awaiting requested review from ktkfree

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertchoi80 @Siyeop