Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0517 alpha test 수정사항 반영 #52

Merged
merged 2 commits into from
May 18, 2023
Merged

0517 alpha test 수정사항 반영 #52

merged 2 commits into from
May 18, 2023

Conversation

cho4036
Copy link
Contributor

@cho4036 cho4036 commented May 17, 2023

UpdateByAccountIdByAdmin

  • NPE 문제 발생
  • 원인:
    • Organization 생성 시 admin 계정을 자동으로 만들며 email은 넣지 않은 채로 생성
    • 이로 인해 비교 구문에서 NPE 발생
  • 해결:
    • NPE 발생 구문 변경 및 빈 값에 대한 업데이트 가능하도록 수정

Field Length 관련 validation

  • 수정사항
    • 이름: (min:3, max:20) -> (min:1, max:30) 자
    • 소속: (min:0, max:50)자

@cho4036 cho4036 requested review from ktkfree and Siyeop May 17, 2023 10:02
@ktkfree ktkfree merged commit c2e9f18 into openinfradev:develop May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktkfree ktkfree ktkfree approved these changes

@Siyeop Siyeop Awaiting requested review from Siyeop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cho4036 @ktkfree