Collect user app pod log #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertchoi80
commented
May 20, 2024
| } | ||
|
|
||
| var out domain.GetAppServeAppLogResponse | ||
| // if err := serializer.Map(r.Context(), podLog, &out.PodLog); err != nil { |
There was a problem hiding this comment.
@ktkfree 님~ 이 부분은 구조체가 아닌 string 값을 복사할 때 아래 에러가 발생하여, map 함수 대신 그냥 단순히 대입하도록 하였는데, 혹시 문제가 될까요? 정상 동작하는건 확인하였습니다.
reflect: call of reflect.Value.NumField on string Value
ktkfree
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
앱서빙을 통해 배포된 사용자 앱의 podLog 및 pod 상태를 UI에서 조회 가능하도록 백엔드에서 수집합니다
우선은 버튼 클릭시마다 1회성으로 로그를 가져와서 보여주도록 구현하였으며, 장기적으로는 web socket 등을 통해 스트림 형태로 로그가 계속 업데이트되어 보여질 수 있는 형태로 진화가 필요합니다.
https://github.com/openinfradev/tks-issues/issues/1110