#bug fix UpdateUser API, #Improvement TemporaryPWGeneration, API Filter #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cho4036
changed the title
Siyeop
reviewed
May 4, 2023
Comment on lines
+23
to
+36
| func TestPasswordGeneration(t *testing.T) { | ||
| length := 8 | ||
| sameCount := 0 | ||
| for i := 0; i < 10000000; i++ { | ||
| firstGenPassword := helper.GenerateRandomString(length) | ||
| secondGenPassword := helper.GenerateRandomString(length) | ||
| if firstGenPassword == secondGenPassword { | ||
| fmt.Printf("Index: %d. It's same %s\n", i, firstGenPassword) | ||
| sameCount++ | ||
| } | ||
| } | ||
| fmt.Println("Same count: ", sameCount) | ||
| fmt.Println("Same ratio: ", float64(sameCount)/100000) | ||
| } |
There was a problem hiding this comment.
assert 구문은 따로 없나요?
0.0001% 미만이면 성공이라든가 그런게 필요할 것 같네요.
10000000 정도면 충분히 큰 수라서 우연히 0.0001% 이상이 나온다던가 그런 일은 없을 것 같습니다.
There was a problem hiding this comment.
if 비교 구문 대신 assert를 사용하면 되나 편의상 간단히 보기 위해 이렇게 처리했어요
go test 정식 사용법은 assert()를 사용함이 맞습니다
Siyeop
reviewed
May 4, 2023
| internal.API_PREFIX + internal.API_VERSION + "/organizations/" + requestUserInfo.GetOrganizationId() + "/my-profile" + "/password", | ||
| internal.API_PREFIX + internal.API_VERSION + "/organizations/" + requestUserInfo.GetOrganizationId() + "/my-profile" + "/next-password-change", | ||
| internal.API_PREFIX + internal.API_VERSION + "/auth/logout", |
Siyeop
reviewed
May 4, 2023
| @@ -1,15 +1,11 @@ | |||
| package helper | |||
|
|
|||
| import ( | |||
| "crypto/rand" | |||
There was a problem hiding this comment.
변경하기 전에는 실제로 동일한 PW 가 나오는 케이스가 발생하고 있었나요?
There was a problem hiding this comment.
천만과 1억도 돌려봤는데 안나왔어요. 어제 말씀해주신 케이스는 정말 신기하네요..
suffle도 넣을까 하였는데 효과 확신도 안들어 넣지 않았어요. crypto package로 변환해보는게 적절할 꺼같아 이번 건은 이렇게 처리했습니다
ktkfree
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix:
Improve: