Find id/pw 기능 추가 & RBAC 기능 추가 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktkfree
reviewed
Apr 26, 2023
ktkfree
reviewed
Apr 26, 2023
internal/delivery/http/user.go
Outdated
| @@ -45,10 +50,9 @@ func NewUserHandler(h usecase.IUserUsecase) IUserHandler { | |||
| // @Router /organizations/{organizationId}/users [post] | |||
| // @Security JWT | |||
| func (u UserHandler) Create(w http.ResponseWriter, r *http.Request) { | |||
| vars := mux.Vars(r) | |||
| organizationId, ok := vars["organizationId"] | |||
| requestUserInfo, ok := request.UserFrom(r.Context()) | |||
There was a problem hiding this comment.
path variable 의 organizationId 가 아닌 token 의 organizationId 를 사용하는 의도가 무엇인가요?
There was a problem hiding this comment.
잘못된 부분 같습니다. 요청자와 요청에 대한 자원의 org가 반드시 같을 것이라 생각했는데 아닐 수 있는 경우에 대해 처리하려면 path variable을 사용하는게 맞는것 같습니다.
수정할게요.
ktkfree
reviewed
Apr 26, 2023
internal/delivery/http/user.go
Outdated
| @@ -259,16 +263,20 @@ func (u UserHandler) Update(w http.ResponseWriter, r *http.Request) { | |||
| ctx := r.Context() | |||
| var user domain.User | |||
| if err = domain.Map(input, &user); err != nil { | |||
| log.Error(err) | |||
| ErrorJSON(w, httpErrors.NewInternalServerError(err)) | |||
There was a problem hiding this comment.
ErrorJSON(w, err) 와 결과는 같습니다. 참고하세요.
ktkfree
reviewed
Apr 26, 2023
internal/helper/util.go
Outdated
| func GenerateEmailCode() string { | ||
| num, err := rand.Int(rand.Reader, big.NewInt(900000)) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
panic 은 위험한 코드입니다. log.error 로 변경해주시고, err 를 리턴하여 caller 에서 error 를 처리하도록 변경해주세요
ktkfree
reviewed
Apr 26, 2023
| User: repository.NewUserRepository(db), | ||
| Cluster: repository.NewClusterRepository(db), | ||
| Organization: repository.NewOrganizationRepository(db), | ||
| AppGroup: repository.NewAppGroupRepository(db), | ||
| AppServeApp: repository.NewAppServeAppRepository(db), | ||
| CloudAccount: repository.NewCloudAccountRepository(db), | ||
| StackTemplate: repository.NewStackTemplateRepository(db), | ||
| Alert: repository.NewAlertRepository(db), |
There was a problem hiding this comment.
제가 올렸던 코드가 빠졌네요. conflit 처리시 miss 가 있었나봅니다. 다시 넣어주세요
ktkfree
reviewed
Apr 26, 2023
| r.Handle(API_PREFIX+API_VERSION+"/organizations/{organizationId}/alerts/{alertId}/actions", authMiddleware.Handle(http.HandlerFunc(alertHandler.CreateAlertAction))).Methods(http.MethodPost) | ||
| //r.Handle(API_PREFIX+API_VERSION+"/organizations/{organizationId}/alerts/{alertId}/actions/status", authMiddleware.Handle(http.HandlerFunc(alertHandler.UpdateAlertActionStatus))).Methods(http.MethodPatch) | ||
|
|
||
| r.HandleFunc(API_PREFIX+API_VERSION+"/alerttest", alertHandler.CreateAlert).Methods(http.MethodPost) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS SES를 통한 id/pw 찾기 기능 추가