Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trivial. remove unused paramter. #313

Merged
merged 1 commit into from
Apr 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions api/swagger/docs.go
Original file line number Diff line number Diff line change
Expand Up @@ -10307,7 +10307,6 @@ const docTemplate = `{
"github_com_openinfradev_tks-api_pkg_domain.CreateSystemNotificationRuleRequest": {
"type": "object",
"required": [
"messageCondition",
"messageContent",
"messageTitle",
"name",
Expand All @@ -10320,9 +10319,6 @@ const docTemplate = `{
"messageActionProposal": {
"type": "string"
},
"messageCondition": {
"type": "string"
},
"messageContent": {
"type": "string"
},
Expand Down Expand Up @@ -13026,9 +13022,6 @@ const docTemplate = `{
"messageActionProposal": {
"type": "string"
},
"messageCondition": {
"type": "string"
},
"messageContent": {
"type": "string"
},
Expand Down Expand Up @@ -13605,7 +13598,6 @@ const docTemplate = `{
"github_com_openinfradev_tks-api_pkg_domain.UpdateSystemNotificationRuleRequest": {
"type": "object",
"required": [
"messageCondition",
"messageContent",
"messageTitle",
"name",
Expand All @@ -13618,9 +13610,6 @@ const docTemplate = `{
"messageActionProposal": {
"type": "string"
},
"messageCondition": {
"type": "string"
},
"messageContent": {
"type": "string"
},
Expand Down
11 changes: 0 additions & 11 deletions api/swagger/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -10301,7 +10301,6 @@
"github_com_openinfradev_tks-api_pkg_domain.CreateSystemNotificationRuleRequest": {
"type": "object",
"required": [
"messageCondition",
"messageContent",
"messageTitle",
"name",
Expand All @@ -10314,9 +10313,6 @@
"messageActionProposal": {
"type": "string"
},
"messageCondition": {
"type": "string"
},
"messageContent": {
"type": "string"
},
Expand Down Expand Up @@ -13020,9 +13016,6 @@
"messageActionProposal": {
"type": "string"
},
"messageCondition": {
"type": "string"
},
"messageContent": {
"type": "string"
},
Expand Down Expand Up @@ -13599,7 +13592,6 @@
"github_com_openinfradev_tks-api_pkg_domain.UpdateSystemNotificationRuleRequest": {
"type": "object",
"required": [
"messageCondition",
"messageContent",
"messageTitle",
"name",
Expand All @@ -13612,9 +13604,6 @@
"messageActionProposal": {
"type": "string"
},
"messageCondition": {
"type": "string"
},
"messageContent": {
"type": "string"
},
Expand Down
8 changes: 0 additions & 8 deletions api/swagger/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1103,8 +1103,6 @@ definitions:
type: string
messageActionProposal:
type: string
messageCondition:
type: string
messageContent:
type: string
messageTitle:
Expand Down Expand Up @@ -1137,7 +1135,6 @@ definitions:
type: string
type: array
required:
- messageCondition
- messageContent
- messageTitle
- name
Expand Down Expand Up @@ -2895,8 +2892,6 @@ definitions:
type: string
messageActionProposal:
type: string
messageCondition:
type: string
messageContent:
type: string
messageTitle:
Expand Down Expand Up @@ -3283,8 +3278,6 @@ definitions:
type: string
messageActionProposal:
type: string
messageCondition:
type: string
messageContent:
type: string
messageTitle:
Expand Down Expand Up @@ -3317,7 +3310,6 @@ definitions:
type: string
type: array
required:
- messageCondition
- messageContent
- messageTitle
- name
Expand Down
1 change: 0 additions & 1 deletion internal/model/system-notification-rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ type SystemNotificationRule struct {
TargetUserIds []string `gorm:"-:all"`
MessageTitle string
MessageContent string
MessageCondition datatypes.JSON
MessageActionProposal string
CreatorId *uuid.UUID `gorm:"type:uuid"`
Creator *User `gorm:"foreignKey:CreatorId"`
Expand Down
1 change: 0 additions & 1 deletion internal/repository/system-notification-rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ func (r *SystemNotificationRuleRepository) Update(ctx context.Context, dto model
//m.SystemNotificationConditions = dto.SystemNotificationConditions
m.MessageTitle = dto.MessageTitle
m.MessageContent = dto.MessageContent
m.MessageCondition = dto.MessageCondition
m.MessageActionProposal = dto.MessageActionProposal
m.UpdatorId = dto.UpdatorId

Expand Down
3 changes: 0 additions & 3 deletions pkg/domain/system-notification-rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ type SystemNotificationRuleResponse struct {
Description string `json:"description"`
MessageTitle string `json:"messageTitle"`
MessageContent string `json:"messageContent"`
MessageCondition string `json:"messageCondition"`
MessageActionProposal string `json:"messageActionProposal"`
TargetUsers []SimpleUserResponse `json:"targetUsers"`
SystemNotificationTemplate SimpleSystemNotificationTemplateResponse `json:"systemNotificationTemplate"`
Expand Down Expand Up @@ -56,7 +55,6 @@ type CreateSystemNotificationRuleRequest struct {
Description string `json:"description"`
MessageTitle string `json:"messageTitle" validate:"required"`
MessageContent string `json:"messageContent" validate:"required"`
MessageCondition string `json:"messageCondition" validate:"required"`
MessageActionProposal string `json:"messageActionProposal"`
TargetUserIds []string `json:"targetUserIds"`
SystemNotificationTemplateId string `json:"systemNotificationTemplateId" validate:"required"`
Expand All @@ -79,7 +77,6 @@ type UpdateSystemNotificationRuleRequest struct {
Description string `json:"description"`
MessageTitle string `json:"messageTitle" validate:"required"`
MessageContent string `json:"messageContent" validate:"required"`
MessageCondition string `json:"messageCondition" validate:"required"`
MessageActionProposal string `json:"messageActionProposal"`
TargetUserIds []string `json:"targetUserIds"`
SystemNotificationTemplateId string `json:"systemNotificationTemplateId" validate:"required"`
Expand Down
Loading