Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix. Reform response data of Permission APIs #310

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

cho4036
Copy link
Contributor

@cho4036 cho4036 commented Mar 28, 2024

240327일 말씀 주신, Permission 관련 Response Body 변경 건입니다.

  • Permissions 배열의 컨텐츠로 "Dashboard, Stack" 과 같은 아우터 key 삭제
  • "is_allowed" -> "isAllowed"로 변경

변경 후 형상

{
    "permissions": [
        {
            "key": "DASHBOARD",
            "children": [
                {
                    "key": "DASHBOARD-DASHBOARD",
                    "children": [
                        {
                            "key": "UPDATE",
                            "isAllowed": true
                        },
                        {
                            "key": "READ",
                            "isAllowed": false
                        }
                    ]
                }
            ]
        },
        {...}
    ]
}

@cho4036 cho4036 requested review from ktkfree and Siyeop March 28, 2024 02:11
Copy link
Member

@Siyeop Siyeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

까막눈이라 코드가 잘 고쳐진건지는 모르지만,
캡쳐해주신 내용만 보면 잘 수정된 것 같습니다.
나연 따봉

@ktkfree ktkfree merged commit 8ed4928 into openinfradev:develop Mar 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants