Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TKS 역할 또는 Project 역할 변경 시, 사용자가 새로운 access token을 발급 받도록 개선 #298

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

cho4036
Copy link
Contributor

@cho4036 cho4036 commented Mar 22, 2024

TKS 역할 또는 Project 역할 변경 시, 기존 토큰을 사용하여 요청을 전송할 경우 아래와 같이 응답.
{
"status": 401,
"code": "A_UNUSABLE_TOKEN",
"message": "token is changed",
"text": "토큰이 변경되었습니다."
}

@Siyeop 시엽님,
기존의 VerifyToken에서 사용되어 alarm을 bypass 할때 사용하였던 error code는 "A_UNUSABLE_TOKEN" -> "A_EXPIRED_TOKEN"로 변경 되었습니다.

Backend:

  • 기존 JWT token lib으로 사용하던 "github.com/dgrijalva/jwt-go" -> "github.com/golang-jwt/jwt" 변경
  • 보안 취약점이 발견된 후 새로운 유지보수자에 의해 "github.com/golang-jwt/jwt"에서 업데이트가 된다고 하여 변경하였습니다.

@cho4036 cho4036 requested review from ktkfree, seungkyua and Siyeop March 22, 2024 10:48
@cho4036
Copy link
Contributor Author

cho4036 commented Mar 22, 2024

'policyTemplateRepo' lint error는 #297 에서 수정하였으므로 Conflict 방지를 위해 그대로 두었습니다.

@ktkfree ktkfree merged commit 0f9916e into openinfradev:develop Mar 25, 2024
2 of 4 checks passed
@cho4036 cho4036 deleted the change_token_after_role_change branch March 28, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants