Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/policytemplates -> /policy-templates, 일부 함수 네이밍 변경 #295

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

sangkenlee
Copy link
Contributor

/policytemplates -> /policy-templates로 API URL 변경

policy-template usecase에서 속성을 조회해서 채워주는 함수들이 Update로 시작되어 혼동되므로 Fill로 시작되도록 변경

@ktkfree
Copy link
Contributor

ktkfree commented Mar 22, 2024

lint 에러 확인 부탁 드립니다.

local에서 golangci-lint run 을 실행하시면 됩니다.

@sangkenlee
Copy link
Contributor Author

lint 에러 확인 부탁 드립니다.

local에서 golangci-lint run 을 실행하시면 됩니다.

$ ~/go/bin/golangci-lint run
WARN [config_reader] The configuration option run.skip-dirs-use-default is deprecated, please use issues.exclude-dirs-use-default.
WARN [config_reader] The configuration option output.format is deprecated, please use output.formats
internal/usecase/organization.go:38:2: field policyTemplateRepo is unused (unused)
policyTemplateRepo repository.IPolicyTemplateRepository
^
제가 관리하는 코드부분에서 발생한 것이 아니어서 제가 수정하면 안 될 듯 합니다.

@ktkfree
Copy link
Contributor

ktkfree commented Mar 22, 2024

lint 에러 확인 부탁 드립니다.
local에서 golangci-lint run 을 실행하시면 됩니다.

$ ~/go/bin/golangci-lint run WARN [config_reader] The configuration option run.skip-dirs-use-default is deprecated, please use issues.exclude-dirs-use-default. WARN [config_reader] The configuration option output.format is deprecated, please use output.formats internal/usecase/organization.go:38:2: field policyTemplateRepo is unused (unused) policyTemplateRepo repository.IPolicyTemplateRepository ^ 제가 관리하는 코드부분에서 발생한 것이 아니어서 제가 수정하면 안 될 듯 합니다.

앗 기존에 났었던 에러군요. 제가 확인하겠습니다!

@ktkfree ktkfree merged commit 6ae52b4 into openinfradev:develop Mar 22, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants