Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix. fix split address #208

Merged
merged 1 commit into from
Nov 15, 2023
Merged

bugfix. fix split address #208

merged 1 commit into from
Nov 15, 2023

Conversation

ktkfree
Copy link
Contributor

@ktkfree ktkfree commented Nov 15, 2023

. tks-endpoint 의 값을 사용할때 포트가 없어 에러가 나는 버그를 수정합니다.
. stack detail 에 kube_type 을 추가합니다.

@ktkfree ktkfree requested a review from Siyeop November 15, 2023 03:41
@ktkfree
Copy link
Contributor Author

ktkfree commented Nov 15, 2023

@Siyeop 님.
stack detail 에 kube_type 을 추가해 두었습니다. 일정 검토하시어 반영여부 확인 바랍니다.

@Siyeop
Copy link
Member

Siyeop commented Nov 15, 2023

6시 전까지 수정하겠습니다.
스트라토 인력 통해서 작업할거라
시간을 딱 정하기는 어렵습니다.

@ktkfree
Copy link
Contributor Author

ktkfree commented Nov 15, 2023

승인해주시면 미리 deploy 해 두겠습니다.

Siyeop
Siyeop approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Siyeop Siyeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍😇

@ktkfree ktkfree merged commit cb76a2c into release Nov 15, 2023
3 checks passed
@ktkfree ktkfree deleted the fix_endpoint branch November 15, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siyeop Siyeop Siyeop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktkfree @Siyeop