Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature. generate clusterId to tks-admin when import admin cluster #187

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

ktkfree
Copy link
Contributor

@ktkfree ktkfree commented Oct 30, 2023

admin cluster 를 import 할때 clusterId 를 "tks-admin" 으로 부여합니다.
randomvalue 의 경우는 argocd cluster 등록시 문제가 발생합니다.

workaround 성 fix 이며, 추후 admin cluster import 에 대한 설계시 고려되어야 하는 부분입니다.

@ktkfree ktkfree requested review from zugwan and cho4036 October 30, 2023 07:15
@cho4036 cho4036 merged commit cc5a938 into release Oct 31, 2023
3 checks passed
@ktkfree ktkfree deleted the fix_import_admin branch January 24, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants