Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature. add combindedFilter to pagination #107

Merged
merged 1 commit into from
Jul 18, 2023
Merged

feature. add combindedFilter to pagination #107

merged 1 commit into from
Jul 18, 2023

Conversation

ktkfree
Copy link
Contributor

@ktkfree ktkfree commented Jul 17, 2023

검색어 ( ID 또는 설명을 입력하세요 ) 류의 복합 or 필터를 위한 combinedFilter param 을 추가합니다.

Siyeop
Siyeop approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@Siyeop Siyeop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Siyeop Siyeop merged commit d334a43 into release Jul 18, 2023
@Siyeop
Copy link
Member

Siyeop commented Jul 18, 2023

머지한 후에 알게된 것이긴 한데,
DB 비교할 때 검색어와 타겟 모두 lowercase로 변환해서 비교해야 할 것 같습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siyeop Siyeop Siyeop approved these changes

@zugwan zugwan Awaiting requested review from zugwan

@bluejayA bluejayA Awaiting requested review from bluejayA

@intelliguy intelliguy Awaiting requested review from intelliguy

@robertchoi80 robertchoi80 Awaiting requested review from robertchoi80

@seungkyua seungkyua Awaiting requested review from seungkyua

@cho4036 cho4036 Awaiting requested review from cho4036

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktkfree @Siyeop