Refactor prepare etcd #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to deal with both TKS and tacoplay
zugwan
approved these changes
Jan 26, 2022
Jaesang
reviewed
Jan 26, 2022
| --from-file=etcd-client-key=/ssl/{{ .Values.etcd.client_keyfile }} | ||
| {{- else if eq .Values.deployer "tacoplay" }} | ||
| --from-file=etcd-ca=/ssl/{{ .Values.etcd.tacoplay_certfile }} \ | ||
| --from-file=etcd-client=/ssl/admin-${MY_NODE_NAME}.pem \ |
There was a problem hiding this comment.
admin pem으로 하면 잘되나요?
판교 prd의 Kube-apiserver 파라미터에는 node를 쓰고 있어요
--etcd-certfile=/etc/ssl/etcd/ssl/node-master02-prd.pem
There was a problem hiding this comment.
adminpem으로 하면 잘되나요? 판교 prd의 Kube-apiserver 파라미터에는node를 쓰고 있어요--etcd-certfile=/etc/ssl/etcd/ssl/node-master02-prd.pem
아, 잘 지적해주셨네요! 안그래도 어제 주관님이 admin 대신 member cert 쓰는게 맞겠다고 의견 주셨거든요. 근데 혹시 member와 node cert의 차이를 아시나요? TKS의 경우에 peer.crt 를 쓰는 걸로 봐서 member 쓰는게 맞는 거 같긴 한데 확실치가 않네요
일단, admin 이나 member 둘 다 해봤는데 잘 동작하고 있습니다.
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
Jaesang
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/openinfradev/tks-issues/issues/39
내용 설명은 위 링크에 있습니다