Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seperate infra provider reference site (aws and byoh) #90

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Conversation

zugwan
Copy link
Contributor

@zugwan zugwan commented Jun 24, 2022

decapod-reference 사이트는 decapod-bootstrap 등 사용하는 부분이 있어 해당 내역 정리 후에 삭제하는 것으로 진행했으면 합니다.

decapod-reference site remains for compatability but must be
deleted someday.
@gitguardian
Copy link

gitguardian bot commented Jun 24, 2022

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
1296558 Slack Webhook URL 219e47b aws-reference/lma/site-values.yaml View secret
2946228 Generic High Entropy Secret 219e47b aws-reference/lma/site-values.yaml View secret
1296558 Slack Webhook URL 14eb114 byoh-reference/lma/site-values.yaml View secret
2946228 Generic High Entropy Secret 14eb114 byoh-reference/lma/site-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ktkfree
Copy link
Contributor

ktkfree commented Jun 30, 2022

render_cd.sh 커밋 외에 나머지는 기존의 decapod-reference 를 그대로 복사한걸로 이해하고 승인합니다.

@robertchoi80
Copy link
Contributor

저도 태규님과 똑같이 이해하고 승인합니다.

@zugwan zugwan merged commit ceaa458 into main Jun 30, 2022
@zugwan zugwan deleted the add_byoh branch June 30, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants