Admin-tools 워크플로우템플릿 추가: keycloak 설치 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugwan
requested review from
Jaesang,
ktkfree,
intelliguy,
robertchoi80 and
seungkyua
ktkfree
approved these changes
Mar 18, 2022
| templateRef: | ||
| name: delete-apps | ||
| template: DeleteAppsByLabel | ||
| arguments: |
There was a problem hiding this comment.
(예전 다른 작업의 결과로 인해) 현재 DeleteAppsByLabel 은 input param이 사라지고 workflow param으로 직접 전달되기 때문에, 이 부분은 삭제해야 할 것 같습니다. 아마 에러 나지 않나요?
| apiVersion: argoproj.io/v1alpha1 | ||
| kind: WorkflowTemplate | ||
| metadata: | ||
| name: admin-tools |
There was a problem hiding this comment.
다른 WF와의 일관성을 위해 명칭을 install-admin-tools 또는 setup-admin-tools 등으로 해주는게 의미가 명확할 것 같습니다.
There was a problem hiding this comment.
저도 말씀하신 것처럼 install 로 시작하려 했으나 LMA, service-mesh 설치 워크플로우 템플릿 모두 해당 이름만 사용하고 있어서 그대로 둔 것이긴 합니다. 워크플로우 템플릿 자체가 TKS 서비스에서 사용하는 인터페이스이니 일단 새로 추가하는 admin-tools 부분만 install- 을 사용하도록 하겠습니다.
zugwan
force-pushed
the
admin-tools-keycloak
branch
from
5fa54ae to
c3597a9
Compare
zugwan
force-pushed
the
admin-tools-keycloak
branch
from
c3597a9 to
0ef4410
Compare
robertchoi80
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keycloak 설치를 위한 워크플로우 템플릿을 추가합니다.