move app_prefix to workflow param #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it can be overriden by parent workflow
Jaesang
approved these changes
Dec 22, 2021
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
ktkfree
reviewed
Dec 28, 2021
|
This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app_prefix 가 개별 template level의 input param으로 되어있다보니, tks-flow/lma -> decapod-flow/lma -> create-app 과 같은 순서로 호출되는 경우, decapod-flow 쪽이 아닌 tks-flow 쪽에서 이 param을 override할 수 있는 방법이 없더군요. 그래서 workflow param으로 변경하여, tks-flow 쪽에서 override할 수 있게 수정하였습니다.