make logging_component selectable #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
zugwan
approved these changes
Dec 20, 2021
|
inferface 변경의 건인데, tks-lma-federation workflow와 tks-cluster-lcm 변경은 필요 없을까요? |
ktkfree
approved these changes
Dec 21, 2021
|
@robertchoi80 create-app 반영된 것과 충돌이 발생하네요. 수정 부탁 드려요. |
아, tks-lma-federation 쪽에서는 'logging_component'라는 workflow param을 추가해야 할 것 같고, lcm에서 직접 수정할 부분은 없을 것 같습니다. tks-flow 쪽에 내용 반영할게요 |
네 지금 수정 중입니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
efk 와 loki 중 선택하여 배포할 수 있도록 lma workflow를 수정하였습니다.
https://github.com/openinfradev/tks-issues/issues/42
현재 파이프라인이 일단 우리가 가진 모든 차트를 decapod-manifests로 렌더링해놓고, 그중에 뭘 배포할지 workflow에서 최종 선택하는 방식이라 kustomize를 활용한 layering이 아니라 본 방식으로 구현하게 되었습니다.