Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TACODEV-798: remove fed-master and unify lma workflows #50

Merged
merged 1 commit into from
Aug 4, 2021
Merged

TACODEV-798: remove fed-master and unify lma workflows #50

merged 1 commit into from
Aug 4, 2021

Conversation

intelliguy
Copy link
Contributor

fed-master 삭제 후 이제 구분이 필요없어진 lma-wf와 lma-federation-wf를 lma-unifored-wf로 변경

@intelliguy intelliguy requested review from Jaesang and seungkyua August 4, 2021 06:40
Jaesang
Jaesang reviewed Aug 4, 2021
View reviewed changes
Copy link
Contributor

@Jaesang Jaesang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

템플릿이름이 그냥 lma-wftpl이 간단하지 않을까요? uniformed의 의미는 무엇인가요?

@intelliguy
Copy link
Contributor Author

intelliguy commented Aug 4, 2021 •
edited
Loading

템플릿이름이 그냥 lma-wftpl이 간단하지 않을까요? uniformed의 의미는 무엇인가요?

그렇게하면 lma-federation-wftpl이 바뀐것인데, lma-wftpl이 바뀐것처럼 잡혀서 파악하기 힘들꺼 같아서 집어넣은 이름입니다.
궂이 의미를 부여하자면 예전에 federation과 아닌것을 구분해서 설치했는데 이제는 모두 하나이다?

@intelliguy intelliguy merged commit 8fc75c2 into main Aug 4, 2021
@intelliguy intelliguy deleted the TACODEV-798 branch August 4, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluejayA bluejayA bluejayA approved these changes

@Jaesang Jaesang Jaesang approved these changes

@seungkyua seungkyua Awaiting requested review from seungkyua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@intelliguy @Jaesang @bluejayA