Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add post-process feature for tks #30

Merged
merged 2 commits into from
Jul 9, 2021
Merged

add post-process feature for tks #30

merged 2 commits into from
Jul 9, 2021

Conversation

intelliguy
Copy link
Contributor

@intelliguy intelliguy commented May 26, 2021 •
edited
Loading

lma-federation-wf에 tks에 연동하여 endpoint를 등록하는 post process추가
입력하는 방법은 다음 3가지

  1. eplist 변수에 json 형태로 어플리케이션별 모든 url 제공 "{"1":"127.0.0.1","2":"127.0.0.1:10232"}"
  2. clusterep에 클러스터에 대한 ip혹은 dns를 명시하고 epportlist변수에 어플리케이션별 포트를 제공 "{"1":"30000","2":"30005"}"
  3. clusterep에 클러스터에 대한 ip 혹은 dns를 적용하여 미리 정해진 내용을 등록하도록 유도 - 현재는 30007 포트만 prometheus sidecar 서비스로 등재

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Jun 4, 2021
@intelliguy intelliguy force-pushed the register-endpoint branch from 4cf3903 to 1a1cead Compare June 7, 2021 12:25
@intelliguy intelliguy removed the Stale There has been no activity on this label Jun 7, 2021
@intelliguy intelliguy mentioned this pull request Jun 7, 2021
Merged
@estherk0
Copy link
Contributor

estherk0 commented Jun 9, 2021

최근 main branch에서 workflows는 모두 workflowTemplate으로 변경되었습니다.
이 파일도 WorkflowTemplate으로 변경부탁드릴게요.

@estherk0
Copy link
Contributor

estherk0 commented Jun 9, 2021

관련 PR입니다. https://github.com/openinfradev/decapod-flow/pull/33/files

@intelliguy intelliguy force-pushed the register-endpoint branch from 1a1cead to 4714b37 Compare June 9, 2021 06:33
@intelliguy intelliguy force-pushed the register-endpoint branch from 4714b37 to be21703 Compare June 9, 2021 07:47
robertchoi80
robertchoi80 reviewed Jun 11, 2021
View reviewed changes
templates/decapod-apps/tks-lma-federation-wftpl.yaml Outdated
value: "6abead61-ff2a-4af4-8f41-d2c44c745de7"
- name: appgroupid
value: "abbead61-ff2a-4af4-8f41-d2c44c745de7"
- name: clusterep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 저처럼 바로 이해를 못하는 경우가 생기지 않도록, 주석을 달아두시죠. 예를 들면,
"An endpoint that is used to access services in the cluster, typically with nodePort. In most cases, it's an IP or domain name of one of k8s master nodes in the cluster"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그리고 PR 설명에는 적어놓으셨지만 PR은 close되고 나면 보지 않으니, parameter를 제공하는 여러 case에 대해 주석이나 또는 간단한 README 파일이라도 필요할 것 같습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위 예시만으로는 부족하므로 pr내용을 붙이는게 낫겠네요

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네, 좋습니다. 그리고 참고로 위의 코멘트 내용은, "cluster endpoint"라는 개념이 일반적으로 사용하는 용어가 아니라서 처음 보면 생소할 수 있어 말씀드린 거였습니다. (api-server endpoint는 있지만, cluster 자체의 ep가 무엇인가? 하고..)

robertchoi80
robertchoi80 requested changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@robertchoi80 robertchoi80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료하였고 코멘트 몇개 남겼습니다

@github-actions
Copy link

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Jun 14, 2021
@estherk0 estherk0 removed the Stale There has been no activity on this label Jun 17, 2021
@github-actions
Copy link

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Jun 20, 2021
@bluejayA bluejayA removed the Stale There has been no activity on this label Jun 21, 2021
@github-actions
Copy link

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Jun 24, 2021
@bluejayA bluejayA removed the Stale There has been no activity on this label Jun 24, 2021
@github-actions
Copy link

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Jun 27, 2021
@bluejayA bluejayA removed the Stale There has been no activity on this label Jun 27, 2021
@bluejayA
Copy link
Contributor

@intelliguy 요청된 change request 에 대한 followup 부탁드립니다

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale There has been no activity on this label Jul 2, 2021
@github-actions
Copy link

github-actions bot commented Jul 5, 2021

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Jul 5, 2021
@intelliguy intelliguy reopened this Jul 7, 2021
@zugwan zugwan requested a review from robertchoi80 July 7, 2021 04:24
@intelliguy intelliguy removed the Stale There has been no activity on this label Jul 7, 2021
@intelliguy intelliguy force-pushed the register-endpoint branch 2 times, most recently from adb96e6 to cdc0e08 Compare July 7, 2021 08:06
@intelliguy intelliguy force-pushed the register-endpoint branch from cdc0e08 to b6134a1 Compare July 7, 2021 08:26
@zugwan zugwan merged commit 1c7a0d4 into main Jul 9, 2021
@zugwan zugwan deleted the register-endpoint branch July 9, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertchoi80 robertchoi80 robertchoi80 approved these changes

@zugwan zugwan zugwan approved these changes

@estherk0 estherk0 Awaiting requested review from estherk0

@Jaesang Jaesang Awaiting requested review from Jaesang

@seungkyua seungkyua Awaiting requested review from seungkyua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@intelliguy @estherk0 @bluejayA @zugwan @robertchoi80