Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add repository_url parameter into application workflow #28

Merged
merged 1 commit into from
May 14, 2021
Merged

add repository_url parameter into application workflow #28

merged 1 commit into from
May 14, 2021

Conversation

estherk0
Copy link
Contributor

  • repository_url은 가변적인 파라미터 이므로 prepare_argocd 설정에서 빼고 application 생성 시점에 설정하도록 변경한다.

@estherk0 estherk0 force-pushed the parameter_repository_url branch from 517f397 to f11cad1 Compare May 14, 2021 04:01
@estherk0 estherk0 force-pushed the parameter_repository_url branch from f11cad1 to 6637311 Compare May 14, 2021 04:02
seungkyua
seungkyua approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@seungkyua seungkyua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seungkyua seungkyua merged commit a6c371a into main May 14, 2021
@estherk0 estherk0 deleted the parameter_repository_url branch June 17, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seungkyua seungkyua seungkyua approved these changes

@zugwan zugwan zugwan approved these changes

@Jaesang Jaesang Awaiting requested review from Jaesang

@intelliguy intelliguy Awaiting requested review from intelliguy

@robertchoi80 robertchoi80 Awaiting requested review from robertchoi80

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estherk0 @zugwan @seungkyua