fix app deletion be stuck #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets the PropagationPolicy as Background.
zugwan
requested review from
ktkfree,
intelliguy,
seungkyua,
kyuho24,
cho4036 and
Siyeop
ktkfree
reviewed
Mar 28, 2023
ktkfree
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArgoCD 에서도 삭제가 멈춰있는 상황에 대한 처리를 위해 PropagationPolicy 옵션으로 기본 foreground 방식에 추가로 Background를 추가하였습니다. 참고: argoproj/argo-cd#5216
App 삭제를 모두 Background 처리하도록 변경하였습니다.