bugfix: thanos-sidecars handle raw data within 3h #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
intelliguy
commented
Jun 15, 2021
intelliguy
commented
- thanos 질의가 수행되지 못하게 되었던 버그 수정
- prometheus내부의 thanos-sidecar에 대한 중복생성 이슈해소
estherk0
reviewed
Jun 16, 2021
| @@ -197,13 +197,16 @@ charts: | |||
| clusterDomain: $(clusterName) | |||
| existingObjstoreSecret: $(thanosObjstoreSecret) | |||
| query.nodeSelector: $(nodeSelector) | |||
| query.dnsDiscovery.sidecarsService: lma-thanos-discovery | |||
There was a problem hiding this comment.
sidecar service name이 lma-thanos-discovery로 생성되나요?
There was a problem hiding this comment.
넵 promehtues 챠트에서 생성합니다.
estherk0
approved these changes
Jun 16, 2021
|
This PR is stale because it has been open 3 days with no activity. Remove stale label or comment or this will be closed in 3 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.